Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Civic Address Country and Regions #1443

Merged
merged 7 commits into from
Jul 21, 2023

Conversation

cameron-eyds
Copy link
Collaborator

@cameron-eyds cameron-eyds commented Jul 20, 2023

Issue #: /bcgov/entity#16946

Description of changes:

  • Implements Civic Address Country option
  • Implements USA Regions when Country is selected
  • Updated Validations
  • Remove/updated labels
  • Updated Review Confirm component to display Country in both Staff/Manu MHRs, as well as MHR Information flow.

Note: Very minor updates not directly related to the scope of Civic Address-

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@cameron-eyds cameron-eyds self-assigned this Jul 20, 2023
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1443-lcbt890j.web.app

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1443 (27e179c) into main (9255e77) will increase coverage by 4.78%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1443      +/-   ##
==========================================
+ Coverage   72.35%   77.13%   +4.78%     
==========================================
  Files         307      338      +31     
  Lines       12767     6198    -6569     
  Branches     2630      983    -1647     
==========================================
- Hits         9237     4781    -4456     
+ Misses       3518     1385    -2133     
- Partials       12       32      +20     
Flag Coverage Δ
pprui 77.13% <ø> (+4.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ppr-ui/src/App.vue 100.00% <ø> (+56.78%) ⬆️
ppr-ui/src/components/collateral/Collateral.vue 100.00% <ø> (+10.97%) ⬆️
...nents/collateral/generalCollateral/GenColAmend.vue 100.00% <ø> (+18.00%) ⬆️
...onents/collateral/generalCollateral/GenColEdit.vue 100.00% <ø> (+15.15%) ⬆️
...nts/collateral/generalCollateral/GenColSummary.vue 100.00% <ø> (+8.00%) ⬆️
...collateral/generalCollateral/GeneralCollateral.vue 100.00% <ø> (+6.66%) ⬆️
...ts/collateral/vehicleCollateral/EditCollateral.vue 100.00% <ø> (+22.58%) ⬆️
...collateral/vehicleCollateral/VehicleCollateral.vue 100.00% <ø> (+19.41%) ⬆️
...cleCollateral/factories/useCollateralValidation.ts 71.42% <ø> (ø)
...llateral/vehicleCollateral/factories/useVehicle.ts 70.14% <ø> (-0.91%) ⬇️
... and 133 more

... and 126 files with indirect coverage changes

Copy link
Contributor

@orelbn orelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1443-lcbt890j.web.app

@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1443-lcbt890j.web.app

@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1443-lcbt890j.web.app

@cameron-eyds cameron-eyds merged commit 701c96e into bcgov:main Jul 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants